Merge lp:~hjd/widelands/utils-cleanup into lp:widelands
Status: | Merged |
---|---|
Merged at revision: | 6996 |
Proposed branch: | lp:~hjd/widelands/utils-cleanup |
Merge into: | lp:widelands |
Diff against target: |
114 lines (+2/-72) 3 files modified
utils/count-longlines.py (+0/-49) utils/create_cppcheck_report (+1/-1) utils/detect_revision.py (+1/-22) |
To merge this branch: | bzr merge lp:~hjd/widelands/utils-cleanup |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
SirVer | Approve | ||
Review via email: mp+224023@code.launchpad.net |
Description of the change
* detect_revsion had the ability to detect git revision, however from what I could see it boiled down to using git-svn to get the svn revision. Feel free to correct me if this still makes sense, but it seems to be a relic from when Widelands lived on sourceforge, was hosted with subversion and someone presumably used git-svn to get nifty features like branches.
* Removed count-longlines.py since line length is checked at compile time by codecheck.
* When reading the cppcheck manpage I discovered that --std=c++11 is the default option. I am not sure how relevant checking against the other standards were (c99 and posix), so I simply removed them, since I figured c++11 was the most important one.
Good changes! Thanks for cleaning up.