widelands

Merge lp:~hjd/widelands/unused-value into lp:widelands

  1. unused-value
  2. Merge into trunk
Proposed by Hans Joachim Desserud
Status: Merged
Merged at revision: 7159
Proposed branch: lp:~hjd/widelands/unused-value
Merge into: lp:widelands
Diff against target: 13 lines (+0/-3)
1 file modified
src/ai/defaultai.cc (+0/-3)
To merge this branch: bzr merge lp:~hjd/widelands/unused-value
Reviewer Review Type Date Requested Status
SirVer Approve
Review via email: mp+228921@code.launchpad.net

Description of the change

Removed variable assignment happening just before returning (found by scan-build). At the same time I removed what I assume is an older version of this check.

To post a comment you must log in.
Revision history for this message
SirVer (sirver) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/ai/defaultai.cc'
2--- src/ai/defaultai.cc 2014-07-28 18:03:51 +0000
3+++ src/ai/defaultai.cc 2014-07-30 17:51:29 +0000
4@@ -1419,10 +1419,7 @@
5 } // end of mines_ section
6
7 // if there is no winner:
8- // if (proposed_building == INVALID_INDEX) {
9 if (best_building == nullptr) {
10-
11- mine = false;
12 return false;
13 }
14

Subscribers

People subscribed via source and target branches

to status/vote changes: