Code review comment for lp:~hjd/widelands/optimizations

Ok, thanks. :) I've pushed some more changes now. Some comments:

If we have a check as part of the stylechecker for this, then I think someone should check whether that still works and is run.

How can logic/building.cc:686 ever be called when the if has the same check as the while loop above?

The cppcheck report also listed logic/tribe.cc:233, but that section looks a bit special and I'm not sure what's going on there, so I left it alone...