Code review comment for lp:~hjd/widelands/more-warnings

Revision history for this message
SirVer (sirver) wrote :

@nicolai: If you have a suggestion of warning detection besides compiling something with the warning enabled (which is quite painful indeed with cmake), let it here.

I agree that we should only get a switch warning when both conditions are true

a) there is no default: label
b) not all cases of an enum are handled in the switch

if this is given by -Wswitch, we should not use switch-enum. hjd, could you double check this please? Maybe also what clang does.

« Back to merge proposal