Merge lp:~hjd/widelands/metalworks-text-bug-734409 into lp:widelands

Proposed by Hans Joachim Desserud
Status: Merged
Merged at revision: 5921
Proposed branch: lp:~hjd/widelands/metalworks-text-bug-734409
Merge into: lp:widelands
Diff against target: 21 lines (+2/-2)
1 file modified
campaigns/t03.wmf/scripting/texts.lua (+2/-2)
To merge this branch: bzr merge lp:~hjd/widelands/metalworks-text-bug-734409
Reviewer Review Type Date Requested Status
Nasenbaer Approve
SirVer Approve
Review via email: mp+63467@code.launchpad.net

Description of the change

(See bug 734409 for details)
Reworked part of the campaign text to avoid confusion around axe factories and blacksmith/master blacksmith.

The change on line 336 is the one who is shown in the story dialog, while the change on line 111 is the reminder shown if the player checks current objectives.

To post a comment you must log in.
Revision history for this message
SirVer (sirver) :
review: Approve
Revision history for this message
Nasenbaer (nasenbaer) wrote :

From me a disapprove - of course your text is nicer to read and I generally like the new texts, but the main problem for me is: the player reads a long sentance and stops somewhere as (s)he is quite sure (s)he already got the point - so propably (s)he misses the *very important* note, that (s)he should only upgrade the building, if the worker reaches the next level....

review: Disapprove
Revision history for this message
SirVer (sirver) wrote :

Hey Peter! Glad to see you around :)

Do you have a suggestions for better wording in this particular case? I feel that the minimum we have to expect from the players is to read the mission texts.

Revision history for this message
Nasenbaer (nasenbaer) wrote :

Hey SirVer :), you'll never get rid of me ;) :-D ...

I just reread the text and I think I was actually wrong - seems things got mixed up after 9 hours of work ;). So approved and will be merged in the next few minutes. :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'campaigns/t03.wmf/scripting/texts.lua'
2--- campaigns/t03.wmf/scripting/texts.lua 2011-01-04 12:17:44 +0000
3+++ campaigns/t03.wmf/scripting/texts.lua 2011-06-04 16:33:36 +0000
4@@ -108,7 +108,7 @@
5 name = "build_weapon_productions",
6 title=_"Build weapon productions",
7 body= "<rt><p line-spacing=3 font-size=12>" ..
8-_"* Enhance your metalworks to an axefactory or - as soon as the blacksmith reaches his next level (master blacksmith) - even to a war mill and build up another metalworks to ensure the production of tools." ..
9+_"* Enhance your metalworks to an axefactory to start producing weapons, and build up another metalworks to ensure the production of tools. When the blacksmith reaches his next level (master blacksmith), you can even enhance your axefactory to a war mill." ..
10 "</p></rt>",
11 }
12
13@@ -333,7 +333,7 @@
14 "<br>" ..
15 _"* Build a battle arena and a trainings camp to the west of the mountains." ..
16 "<br>" ..
17-_"* As soon as the blacksmith reaches his next level (master blacksmith) enhance your metalworks to an axefactory or even a war mill and build up another metalworks to ensure the production of tools." ..
18+_"* Enhance your metalworks to an axefactory in order to produce weapons and build up another metalworks to ensure the production of tools. When the blacksmith reaches his next level (master blacksmith), you can even enhance it to a war mill which produces additional weapons." ..
19 "<br>" ..
20 _"* Build a helmsmithy to the west of the mountains to provide your soldiers with better armor." ..
21 "</p></rt>",

Subscribers

People subscribed via source and target branches

to status/vote changes: