widelands

Merge lp:~hjd/widelands/codecheck-whitespace into lp:widelands

  1. codecheck-whitespace
  2. Merge into trunk
Proposed by Hans Joachim Desserud
Status: Merged
Merged at revision: 7508
Proposed branch: lp:~hjd/widelands/codecheck-whitespace
Merge into: lp:widelands
Diff against target: 12 lines (+1/-1)
1 file modified
cmake/codecheck/rules/no_using_namespace_in_header_files (+1/-1)
To merge this branch: bzr merge lp:~hjd/widelands/codecheck-whitespace
Reviewer Review Type Date Requested Status
GunChleoc Approve
Review via email: mp+267431@code.launchpad.net

Description of the change

See commit message for details.

Codecheck works fine again with Python3 after applying this patch.

To post a comment you must log in.
Revision history for this message
GunChleoc (gunchleoc) wrote :

LGTM :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmake/codecheck/rules/no_using_namespace_in_header_files'
2--- cmake/codecheck/rules/no_using_namespace_in_header_files 2015-07-31 14:57:43 +0000
3+++ cmake/codecheck/rules/no_using_namespace_in_header_files 2015-08-08 11:07:30 +0000
4@@ -5,7 +5,7 @@
5 if "system_headers.h" in fn:
6 return []
7 if not fn.endswith(".h"):
8- return []
9+ return []
10 for lineno, line in enumerate(lines, 1):
11 if "using namespace" in line:
12 return [ (fn, lineno,

Subscribers

People subscribed via source and target branches

to status/vote changes: