Code review comment for lp:~hjd/apport/runit-bugpattern

On Wed, Jan 25, 2017 at 06:03:02PM -0000, Hans Joachim Desserud wrote:
> Good catch with the forward slashes, I totally forgot.
> I note that test-local report a match both with and without, but it seems better to have them there.
>
> 1. Sorry for being unclear. I assume the Package key is used to match the package where the error occured to check if it is the same or just a similar problem in a different package, but I am not sure how it decides which package name should be check.

The "Package" key is searched for in the bug description e.g. "Package:
git-daemon-run 1:2.7.4-0ubuntu1" from LP: #1625798.

> The issue occurs when installing runit, so if I install that package
> alone, the error triggers and it will match the Package key. In this
> case the error originates from the package, and it's a pretty
> straight-forward case. If I instead attempt to install git-daemon-run,
> this will pull in runit as a dependency and fail as well. Will it then
> try to match runit or git-daemon-run against the Package key?

git-daemon-run because that's what'll be in the Package field for the
report.

> Because the error always occurs in runit, but it might be triggered
> when installing other packages that depend on it, should those then be
> listed as alternatives?

Yes, I think so. You might use "apt-cache rdepends runit" and check
those packages for bugs like this too.

> 2. Ok, as long as the real-world use won't have similar problems, I
> can live with that. I tested manually with some of the other
> duplicates.
>
> 3. That's a good point. Though at least for runit directly, I've
> marked the duplicates manually. The remaining bugs there seemed to be
> either unrelated or with different error messages, so I'm not sure
> what's up with those.

--
Brian Murray
Ubuntu Bug Master