Code review comment for lp:~hingo/drizzle/drizzle-the-version-is-7.1-not-a-date-and-certainly-not-7

Vijay

I don't understand your reasoning.

Without this patch:
 - bzr tag 2012.02.31 will work
 - bzr tag 7.1.31 will not pass tests

With this patch:
 - bzr tag 2012.02.31 will work
 - bzr tag 7.1.31 will not work

What do you have against this patch? Why don't you propose to remove other random patches which also have nothing to do with the problem?

As I see it the problem is:

 - there's one test that tests for SELECT ... /*!72301 + */. Since the version number is changed, the test result must be changed accordingly, but there is no bug. (In fact, until now the test has been testing the wrong thing...)

 - drizzledump uses version number to "detect" whether it is connected to mysqld or drizzled. This is a bit embarrasing, for 15 years now we have been laughing at JavaScript developers that try to do this, and they always fail. So this is a bug in drizzledump that needs to be fixed. (I have never touched drizzledump code and this patch has nothing to do with this bug.)

 - Are there more test failures?