Nux

Code review comment for lp:~hikiko/nux/nux.fix-minor-errors-warnings

Revision history for this message
Eleni Maria Stea (hikiko) wrote :

Thanks a lot for the review!
I'm about to fix the lines that cause the failures.

Just a question about:
105 +// , bCaptionAvailable(false)
118 +// bool bCaptionAvailable;
131 +// , bCaptionAvailable(false)
etc
I 've seen that in Nux/GroupBox.cpp Nux/GroupBox2.cpp and a few other places there are some commented-out conditions depending on these variables. For example: http://paste.ubuntu.com/6363550/ shows some relevant code from GroupBox.cpp. Those comments were the reason I didn't entirely delete the declarations: I thought someone left them there intentionally and he might need to put back the conditions at some point. If that's not the case then I should probably remove both the variables and the commented out code to not confuse us anymore. What do you think?

« Back to merge proposal