Nux

Code review comment for lp:~hikiko/nux/arb-srgba-shader

Revision history for this message
Tim Penhey (thumper) wrote :

  NuxGraphics/GraphicsEngine.cpp

Take a look at the merge proposal diff. You can see that you
have a few tabs there instead of spaces :-)

> NuxGraphics/RenderingPipe.cpp

Please keep the # directives in line at the start of the line.

As a general curiousity, how does this method work? It doesn't
return anything. Is it modifying the texture passed in as
the "tex" param?

> void GraphicsEngine::InitAsmSRGBShader()

For the shaders here... please use "const char*" instead
of "std::string". It expresses intent perfectly fine, we are not
modifying the string at all, and it means you don't need the
.c_str() call in the load shader commands. I've been talking
with Michi about this too, and I think we will be changing them
all soonish.

Same thing for the other init shader methods.

gputests/Makefile.am also has tabs

as does teh gamma_correction.cpp file.

review: Needs Fixing

« Back to merge proposal