Mir

Code review comment for lp:~hikiko/mir/mir.dest-tmp

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

1. I think we went off topic when noexcept was added to:
+ virtual ~MockAndroidRegistrar() {}
+ virtual ~MockANativeWindow() {}
+ virtual ~MockImplementation() {}
That really should be a separate proposal as this one was meant to be just about fixing virtual destructors... ?

2. This change is still unnecessary as it's already included in -Wall:
60 -set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -std=c++0x -Werror -Wall -fno-strict-aliasing -pedantic -Wextra -fPIC")
61 +set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -std=c++0x -Werror -Wall -fno-strict-aliasing -pedantic -Wnon-virtual-dtor -Wextra -fPIC")
Making the global CMAKE_CXX_FLAGS unnecessarily more complex is something to avoid.

3. Various blank lines have been added and removed. And in some cases they're the only change made to a file, so should be undone.

review: Needs Fixing

« Back to merge proposal