Mir

Code review comment for lp:~hikiko/mir/mir.dest-tmp

  1. mir.dest-tmp
  2. Merge into trunk
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> Not fixed :(

Too terse?

106 - virtual ~BufferSwapper() = default;
107 + virtual ~BufferSwapper() {/* TODO: make nothrow */}

See above comments about BufferBundle (the previous name of BufferSwapper)

210 + virtual ~BufferStream() {}

Missing "TODO make noexcept" - also part of the BufferXXX renames

413 + virtual ~ANativeWindowInterface() {}
421 + ~MockANativeWindow() {}
434 + virtual ~Interface() {}
441 + ~MockImplementation() {}

See above comments about these

« Back to merge proposal