Mir

Code review comment for lp:~hikiko/mir/mir.dest-tmp

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

> 5. Pointless comment:
> 356 +//do not remove this empty destructor (unique_ptr)

The situation is that we need to have a destructor defined in the source file, instead of in the header (including the compiler generated one), for unique_ptr to an incomplete type to work. The comment could have more details about what is going on, to avoid the "pointless comment" concerns.

I am ok with not having any comment, although that could mean that in the future someone may be tempted to clean this up, only to find that they have wasted their time in vain.

« Back to merge proposal