Mir

Code review comment for lp:~hikiko/mir/mir.dest-tmp

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

413 + virtual ~ANativeWindowInterface() {}
...
421 + virtual ~MockANativeWindow() {}

As you're already changing both classes you should put the "default" and "noexcept" in there now.

~~~~

434 + virtual ~Interface() {}
...
441 + virtual ~MockImplementation() {}

As you're already changing both classes you should put the "default" and "noexcept" in there now.

~~~~

135 + virtual ~Display() {}
212 + virtual ~BufferStream() {}
225 + virtual ~ICSAllocInterface() {}

Missing "TODO make noexcept"

review: Needs Fixing

« Back to merge proposal