Mir

Code review comment for lp:~hikiko/mir/mir.dest-tmp

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> The noexcept was removed from BasicBundle to solve the looser specifier error
> we get because of that: https://code.launchpad.net/~hikiko/mir/mir.fix-virt-
> destructorS/+merge/167705/comments/372088 in gcc
...
> If I put the noexcept back I'll have to add virtual noexcept destructors to
> all the classes that inherit from it and the diff will be even bigger - if
> that's not a problem I can make the change (but it was already discussed and
> the suggestion was to remove the noexcept/default from base classes)

On trunk the code is already compiling with noexcept (and without changes to other classes).

« Back to merge proposal