Mir

Code review comment for lp:~hikiko/mir/mir.dest-tmp

Revision history for this message
Eleni Maria Stea (hikiko) wrote :

@Alan, @Daniel thanks, I fixed the:
BufferStreamSurfaces, AgingBuffer, AndroidClientBuffer, MirBasicRpcChannel, MirSocketRpcChannel

The noexcept was removed from BasicBundle to solve the looser specifier error we get because of that: https://code.launchpad.net/~hikiko/mir/mir.fix-virt-destructorS/+merge/167705/comments/372088 in gcc

Specifically:
[...]
In file included from /home/eleni/staging/destructors/mir.dest-tmp/src/server/compositor/switching_bundle.cpp:22:0:
/home/eleni/staging/destructors/mir.dest-tmp/src/server/compositor/switching_bundle.h:37:7: error: looser throw specifier for ‘virtual mir::compositor::SwitchingBundle::~SwitchingBundle()
In file included from /home/eleni/staging/destructors/mir.dest-tmp/src/server/compositor/switching_bundle.h:23:0,
                 from /home/eleni/staging/destructors/mir.dest-tmp/src/server/compositor/switching_bundle.cpp:22:
/home/eleni/staging/destructors/mir.dest-tmp/src/server/compositor/buffer_bundle.h:35:13: error: overriding ‘virtual mir::compositor::BufferBundle::~BufferBundle() noexcept (true)’
[...]

If I put the noexcept back I'll have to add virtual noexcept destructors to all the classes that inherit from it and the diff will be even bigger - if that's not a problem I can make the change (but it was already discussed and the suggestion was to remove the noexcept/default from base classes)

« Back to merge proposal