Mir

Code review comment for lp:~hikiko/mir/mir.dest-tmp

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

97 - ~BufferStreamSurfaces();
98 + virtual ~BufferStreamSurfaces();

Not needed - this is not a base class

263 - ~AgingBuffer() noexcept {};
264 + virtual ~AgingBuffer() noexcept {}

Not needed - this is not a base class

276 - ~AndroidClientBuffer() noexcept;
277 + virtual ~AndroidClientBuffer() noexcept;

Not needed - this is not a base class

315 - ~MirBasicRpcChannel();
316 + virtual ~MirBasicRpcChannel();

Not needed - this is not a base class

328 - ~MirSocketRpcChannel();
329 + virtual ~MirSocketRpcChannel();

Not needed - this is not a base class

341 - virtual ~BufferBundle() noexcept {}
342 + virtual ~BufferBundle() {}

Looks like a backward step

review: Needs Fixing

« Back to merge proposal