Code review comment for lp:~hikiko/mir/mir.dest-tmp

139 - ~Display() = default;
140 + virtual ~Display() {}

296 + virtual ~MirBasicRpcChannel();

309 + virtual ~MirSocketRpcChannel();

335 + virtual ~ReadLock(){}

344 + virtual ~WriteLock(){}

414 + virtual ~SynchronizerController() {}

Missing "TODO make noexcept" (unless it can be done already).

~~~~

321 - virtual ~BufferSwapperMaster() noexcept {}
322 + virtual ~BufferSwapperMaster() {}

Looks like a backward step

~~~~

435 + virtual ~Interface() {}
...
442 + virtual ~MockImplementation() {}

As you're changing both classes you can put the "default" and "noexcept" in there.