Mir

Code review comment for lp:~hikiko/mir/mir.1238000

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

> I unset it in both places because if a test runs after the bypass_disables_via_environment unit
> test but before the new setup, it might fail.

I don't think that's needed; SetUp() is run before every test is executed. From the googletest FAQ:

"The first thing to remember is that Google Test does not reuse the same test fixture object across multiple tests. For each TEST_F, Google Test will create a fresh test fixture object, immediately call SetUp(), run the test, call TearDown(), and then immediately delete the test fixture object."

« Back to merge proposal