Merge lp:~hggdh2/ubuntu/oneiric/ajaxterm/bug795159 into lp:ubuntu/oneiric/ajaxterm

Proposed by C de-Avillez
Status: Merged
Merged at revision: 16
Proposed branch: lp:~hggdh2/ubuntu/oneiric/ajaxterm/bug795159
Merge into: lp:ubuntu/oneiric/ajaxterm
Diff against target: 85 lines (+42/-2)
5 files modified
debian/changelog (+10/-0)
debian/control (+2/-1)
debian/patches/93_bug795159.diff (+18/-0)
debian/patches/series (+1/-0)
debian/rules (+11/-1)
To merge this branch: bzr merge lp:~hggdh2/ubuntu/oneiric/ajaxterm/bug795159
Reviewer Review Type Date Requested Status
Kees Cook Approve
Review via email: mp+71963@code.launchpad.net

Description of the change

adjust as requested for bug 795159:

    + debian/patches/93_bug795159.diff: removed add to sys.path at beginning
      of the code (unneeded, potential security issue);
    + debian/patches/series: adjusted for above patch;
    + debian/rules: delete auto-installed /usr/share/python/runtime.d
    + debian/control: adjusted Maintainer field.

To post a comment you must log in.
18. By C de-Avillez

additional corrections requested by Daviey on personal chat.

Revision history for this message
Kees Cook (kees) wrote :

Looks good, thanks! I've made some small changes to the Description, added the newly-created Debian bug, and slightly cleaned up the changelog entry to match.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2011-04-17 09:32:01 +0000
+++ debian/changelog 2011-08-18 01:12:31 +0000
@@ -1,3 +1,13 @@
1ajaxterm (0.10-11ubuntu1) oneiric; urgency=low
2
3 * Resolutions for issues outlined in MIR - LP: #795159:
4 + debian/patches/93_bug795159.diff: removed add to sys.path at beginning
5 of the code (unneeded, potential security issue);
6 + debian/rules: delete auto-installed /usr/share/python/runtime.d
7 (LP: #795159)
8
9 -- C de-Avillez <hggdh2@ubuntu.com> Wed, 17 Aug 2011 12:29:51 -0500
10
1ajaxterm (0.10-11) unstable; urgency=low11ajaxterm (0.10-11) unstable; urgency=low
212
3 * Switch from pysupport to dh_python2 13 * Switch from pysupport to dh_python2
414
=== modified file 'debian/control'
--- debian/control 2011-04-17 09:32:01 +0000
+++ debian/control 2011-08-18 01:12:31 +0000
@@ -1,7 +1,8 @@
1Source: ajaxterm1Source: ajaxterm
2Section: web2Section: web
3Priority: optional3Priority: optional
4Maintainer: Julien Valroff <julien@debian.org>4XSBC-Original-Maintainer: Julien Valroff <julien@debian.org>
5Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5Build-Depends: debhelper (>= 8), python (>= 2.6.6-3)6Build-Depends: debhelper (>= 8), python (>= 2.6.6-3)
6Standards-Version: 3.9.27Standards-Version: 3.9.2
7X-Python-Version: >= 2.38X-Python-Version: >= 2.3
89
=== added file 'debian/patches/93_bug795159.diff'
--- debian/patches/93_bug795159.diff 1970-01-01 00:00:00 +0000
+++ debian/patches/93_bug795159.diff 2011-08-18 01:12:31 +0000
@@ -0,0 +1,18 @@
1Description: Ubuntu-requested changes introduced in version 0.10-11ubuntu1
2Author: C de-Avillez <hggdh2@ubuntu.com>
3Bug-Ubuntu: https://bugs.launchpad.net/bugs/795159
4Forwarded: no
5Reviewed-By: <name and email of someone who approved the patch>
6Last-Update: 2011-07-17
7
8--- ajaxterm-0.10.orig/ajaxterm.py
9+++ ajaxterm-0.10/ajaxterm.py
10@@ -18,8 +18,6 @@ except ImportError:
11 sha1 = sha.new
12
13 os.chdir(os.path.normpath(os.path.dirname(__file__)))
14-# Optional: Add QWeb in sys path
15-sys.path[0:0]=glob.glob('../../python')
16
17 import qweb, codecs
18 utf8decoder = codecs.getincrementaldecoder('utf8')()
019
=== modified file 'debian/patches/series'
--- debian/patches/series 2011-04-17 09:32:01 +0000
+++ debian/patches/series 2011-08-18 01:12:31 +0000
@@ -14,3 +14,4 @@
1440_more-ctrl-catches.diff1440_more-ctrl-catches.diff
1590_token_based_access_control.diff1590_token_based_access_control.diff
1691_terminate_on_idle.diff1691_terminate_on_idle.diff
1793_bug795159.diff
1718
=== modified file 'debian/rules'
--- debian/rules 2011-04-17 09:32:01 +0000
+++ debian/rules 2011-08-18 01:12:31 +0000
@@ -1,6 +1,16 @@
1#!/usr/bin/make -f1#!/usr/bin/make -f
2
3PACKAGE = $(shell dh_listpackages)
4TMP = $(CURDIR)/debian/$(PACKAGE)
5
2%:6%:
3 dh $@ --with python27 dh $@ --with python2
48
5override_dh_auto_configure:9override_dh_auto_configure:
6 ./configure --prefix=debian/ajaxterm/usr --confdir=debian/ajaxterm/etc10 ./configure --prefix=$(TMP)/usr --confdir=$(TMP)/etc
11
12override_dh_python2:
13 dh_python2
14 rm -rf $(TMP)/usr/share/python/runtime.d/
15
16.PHONY: override_dh_python2

Subscribers

People subscribed via source and target branches

to all changes: