Merge lp:~hggdh2/ubuntu/oneiric/ajaxterm/bug795159 into lp:ubuntu/oneiric/ajaxterm

Proposed by C de-Avillez
Status: Merged
Merged at revision: 16
Proposed branch: lp:~hggdh2/ubuntu/oneiric/ajaxterm/bug795159
Merge into: lp:ubuntu/oneiric/ajaxterm
Diff against target: 85 lines (+42/-2)
5 files modified
debian/changelog (+10/-0)
debian/control (+2/-1)
debian/patches/93_bug795159.diff (+18/-0)
debian/patches/series (+1/-0)
debian/rules (+11/-1)
To merge this branch: bzr merge lp:~hggdh2/ubuntu/oneiric/ajaxterm/bug795159
Reviewer Review Type Date Requested Status
Kees Cook Approve
Review via email: mp+71963@code.launchpad.net

Description of the change

adjust as requested for bug 795159:

    + debian/patches/93_bug795159.diff: removed add to sys.path at beginning
      of the code (unneeded, potential security issue);
    + debian/patches/series: adjusted for above patch;
    + debian/rules: delete auto-installed /usr/share/python/runtime.d
    + debian/control: adjusted Maintainer field.

To post a comment you must log in.
18. By C de-Avillez

additional corrections requested by Daviey on personal chat.

Revision history for this message
Kees Cook (kees) wrote :

Looks good, thanks! I've made some small changes to the Description, added the newly-created Debian bug, and slightly cleaned up the changelog entry to match.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-04-17 09:32:01 +0000
3+++ debian/changelog 2011-08-18 01:12:31 +0000
4@@ -1,3 +1,13 @@
5+ajaxterm (0.10-11ubuntu1) oneiric; urgency=low
6+
7+ * Resolutions for issues outlined in MIR - LP: #795159:
8+ + debian/patches/93_bug795159.diff: removed add to sys.path at beginning
9+ of the code (unneeded, potential security issue);
10+ + debian/rules: delete auto-installed /usr/share/python/runtime.d
11+ (LP: #795159)
12+
13+ -- C de-Avillez <hggdh2@ubuntu.com> Wed, 17 Aug 2011 12:29:51 -0500
14+
15 ajaxterm (0.10-11) unstable; urgency=low
16
17 * Switch from pysupport to dh_python2
18
19=== modified file 'debian/control'
20--- debian/control 2011-04-17 09:32:01 +0000
21+++ debian/control 2011-08-18 01:12:31 +0000
22@@ -1,7 +1,8 @@
23 Source: ajaxterm
24 Section: web
25 Priority: optional
26-Maintainer: Julien Valroff <julien@debian.org>
27+XSBC-Original-Maintainer: Julien Valroff <julien@debian.org>
28+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
29 Build-Depends: debhelper (>= 8), python (>= 2.6.6-3)
30 Standards-Version: 3.9.2
31 X-Python-Version: >= 2.3
32
33=== added file 'debian/patches/93_bug795159.diff'
34--- debian/patches/93_bug795159.diff 1970-01-01 00:00:00 +0000
35+++ debian/patches/93_bug795159.diff 2011-08-18 01:12:31 +0000
36@@ -0,0 +1,18 @@
37+Description: Ubuntu-requested changes introduced in version 0.10-11ubuntu1
38+Author: C de-Avillez <hggdh2@ubuntu.com>
39+Bug-Ubuntu: https://bugs.launchpad.net/bugs/795159
40+Forwarded: no
41+Reviewed-By: <name and email of someone who approved the patch>
42+Last-Update: 2011-07-17
43+
44+--- ajaxterm-0.10.orig/ajaxterm.py
45++++ ajaxterm-0.10/ajaxterm.py
46+@@ -18,8 +18,6 @@ except ImportError:
47+ sha1 = sha.new
48+
49+ os.chdir(os.path.normpath(os.path.dirname(__file__)))
50+-# Optional: Add QWeb in sys path
51+-sys.path[0:0]=glob.glob('../../python')
52+
53+ import qweb, codecs
54+ utf8decoder = codecs.getincrementaldecoder('utf8')()
55
56=== modified file 'debian/patches/series'
57--- debian/patches/series 2011-04-17 09:32:01 +0000
58+++ debian/patches/series 2011-08-18 01:12:31 +0000
59@@ -14,3 +14,4 @@
60 40_more-ctrl-catches.diff
61 90_token_based_access_control.diff
62 91_terminate_on_idle.diff
63+93_bug795159.diff
64
65=== modified file 'debian/rules'
66--- debian/rules 2011-04-17 09:32:01 +0000
67+++ debian/rules 2011-08-18 01:12:31 +0000
68@@ -1,6 +1,16 @@
69 #!/usr/bin/make -f
70+
71+PACKAGE = $(shell dh_listpackages)
72+TMP = $(CURDIR)/debian/$(PACKAGE)
73+
74 %:
75 dh $@ --with python2
76
77 override_dh_auto_configure:
78- ./configure --prefix=debian/ajaxterm/usr --confdir=debian/ajaxterm/etc
79+ ./configure --prefix=$(TMP)/usr --confdir=$(TMP)/etc
80+
81+override_dh_python2:
82+ dh_python2
83+ rm -rf $(TMP)/usr/share/python/runtime.d/
84+
85+.PHONY: override_dh_python2

Subscribers

People subscribed via source and target branches

to all changes: