- I suggest moving the getSolrSuggestUrl() method from tx_dlf_search_suggest to tx_dlf_solr. Also it should respect username and password if necessary (see solrConnect() in tx_dlf_solr) and handle the core correctly (currently the core isn't regarded at all although there is a variable named $core).
- According to the Coding Guidelines tx_dlf_search_suggest should be a child of tx_dlf_plugin instead of tslib_pibase.
- Please make all private methods protected in order to allow proper class inheritage.
Great work, but there are some more things to do:
- Please add t3jquery to the dependencies in ext_emconf.php.
- Check for the extension to be loaded und use its API to integrate the libraries. typo3.org/ extension- manuals/ t3jquery/ 2.2.0/view/ 1/5/)
(see http://
- I suggest moving the getSolrSuggestUrl() method from tx_dlf_ search_ suggest to tx_dlf_solr. Also it should respect username and password if necessary (see solrConnect() in tx_dlf_solr) and handle the core correctly (currently the core isn't regarded at all although there is a variable named $core).
- According to the Coding Guidelines tx_dlf_ search_ suggest should be a child of tx_dlf_plugin instead of tslib_pibase.
- Please make all private methods protected in order to allow proper class inheritage.
Thanks! :o)