Merge lp:~henrik-lochmann/goobi-presentation/bug-1049565 into lp:~slub.team/goobi-presentation/old-bzr-trunk

Proposed by Henrik Lochmann
Status: Merged
Approved by: Sebastian Meyer
Approved revision: 115
Merged at revision: 115
Proposed branch: lp:~henrik-lochmann/goobi-presentation/bug-1049565
Merge into: lp:~slub.team/goobi-presentation/old-bzr-trunk
Diff against target: 66 lines (+22/-2)
2 files modified
dlf/plugins/listview/class.tx_dlf_listview.php (+16/-2)
dlf/plugins/listview/locallang.xml (+6/-0)
To merge this branch: bzr merge lp:~henrik-lochmann/goobi-presentation/bug-1049565
Reviewer Review Type Date Requested Status
Sebastian Meyer Approve
Review via email: mp+123941@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sebastian Meyer (sebastian-meyer) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'dlf/plugins/listview/class.tx_dlf_listview.php'
--- dlf/plugins/listview/class.tx_dlf_listview.php 2012-08-22 19:22:29 +0000
+++ dlf/plugins/listview/class.tx_dlf_listview.php 2012-09-12 12:24:27 +0000
@@ -293,6 +293,17 @@
293293
294 }294 }
295295
296 $sorting .= '</select>';
297
298 // sort direction
299 $uniqId = uniqid($prefix.'-');
300
301 $sorting .= '<label for="'.$uniqId.'">'.$this->pi_getLL('direction', '', TRUE).'</label><select id="'.$uniqId.'" name="'.$this->prefixId.'[direction]" onchange="javascript:this.form.submit();">';
302
303 $sorting .= '<option value="asc" '.(($this->list->metadata['options']['order_direction'] === 'asc') ? ' selected="selected"' : '').'>'.$this->pi_getLL('direction.asc', '', TRUE).'</option>';
304
305 $sorting .= '<option value="desc" '.(($this->list->metadata['options']['order_direction'] === 'desc') ? ' selected="selected"' : '').'>'.$this->pi_getLL('direction.desc', '', TRUE).'</option>';
306
296 $sorting .= '</select></div></form>';307 $sorting .= '</select></div></form>';
297308
298 return $sorting;309 return $sorting;
@@ -457,15 +468,18 @@
457 $this->list = t3lib_div::makeInstance('tx_dlf_list');468 $this->list = t3lib_div::makeInstance('tx_dlf_list');
458469
459 // Sort the list if applicable.470 // Sort the list if applicable.
460 if (!empty($this->piVars['order']) && $this->piVars['order'] != $this->list->metadata['options']['order']) {471 if ((!empty($this->piVars['order']) && $this->piVars['order'] != $this->list->metadata['options']['order'])
472 || (!empty($this->piVars['direction']) && $this->piVars['direction'] != $this->list->metadata['options']['order_direction'])) {
461473
462 // Order list by given field.474 // Order list by given field.
463 $this->list->sort($this->piVars['order'], TRUE);475 $this->list->sort($this->piVars['order'], $this->piVars['direction'] === 'asc' ? TRUE : FALSE);
464476
465 // Update list's metadata.477 // Update list's metadata.
466 $listMetadata = $this->list->metadata;478 $listMetadata = $this->list->metadata;
467479
468 $listMetadata['options']['order'] = $this->piVars['order'];480 $listMetadata['options']['order'] = $this->piVars['order'];
481
482 $listMetadata['options']['order_direction'] = $this->piVars['direction'];
469483
470 $this->list->metadata = $listMetadata;484 $this->list->metadata = $listMetadata;
471485
472486
=== modified file 'dlf/plugins/listview/locallang.xml'
--- dlf/plugins/listview/locallang.xml 2012-08-14 15:39:30 +0000
+++ dlf/plugins/listview/locallang.xml 2012-09-12 12:24:27 +0000
@@ -20,6 +20,9 @@
20 <label index="skip">...</label>20 <label index="skip">...</label>
21 <label index="orderBy">Order by: </label>21 <label index="orderBy">Order by: </label>
22 <label index="relevance">relevance</label>22 <label index="relevance">relevance</label>
23 <label index="direction">Direction:</label>
24 <label index="direction.asc">ascending</label>
25 <label index="direction.desc">descending</label>
23 <label index="noTitle">[no title]</label>26 <label index="noTitle">[no title]</label>
24 </languageKey>27 </languageKey>
25 <languageKey index="de" type="array">28 <languageKey index="de" type="array">
@@ -37,6 +40,9 @@
37 <label index="skip">...</label>40 <label index="skip">...</label>
38 <label index="orderBy">Sortieren nach: </label>41 <label index="orderBy">Sortieren nach: </label>
39 <label index="relevance">Relevanz</label>42 <label index="relevance">Relevanz</label>
43 <label index="direction">Richtung:</label>
44 <label index="direction.asc">aufsteigend</label>
45 <label index="direction.desc">absteigend</label>
40 <label index="noTitle">[kein Titel]</label>46 <label index="noTitle">[kein Titel]</label>
41 </languageKey>47 </languageKey>
42 </data>48 </data>

Subscribers

People subscribed via source and target branches