Code review comment for lp:~henninge/launchpad/devel-710591-setcurrenttranslation-extension

Revision history for this message
Henning Eggers (henninge) wrote :

Thank you for the review. I split the method into two called "acceptFromImport" and "acceptFromUpstreamImportOnPackage", this way it is clear that this is a special case and the "old style" is gone, too. I also applied your suggestion from IRC to use the explicit flag names and added an assert that acceptFromUpstreamImportOnPackage can only be used on a source package.

I fail to produce an incremental diff as I had to merge devel to get some helpful factory additions that Aaron did. He added a "side" parameter to makePOTemplate and makePOFile so that it now much easier to test with source package templates.

« Back to merge proposal