Code review comment for lp:~henninge/launchpad/devel-710591-importer

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Beautiful.

In accordance to my personal prove-you're-really-reading-it policy, I managed to find one very very minor thing to comment on:

107 + # - The by_maintainer flag must be set.

You may want to mention where this flag is (on the import-queue entry), since it's not where the reader would be most likely to look for it. You could say something like "the translation must come from an upload with the by_maintainer flag set."

Jeroen

review: Approve (code)

« Back to merge proposal