Merge lp:~henninge/launchpad/bug-557347-packaging into lp:launchpad
Proposed by
Henning Eggers
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Henning Eggers | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 10902 | ||||
Proposed branch: | lp:~henninge/launchpad/bug-557347-packaging | ||||
Merge into: | lp:launchpad | ||||
Prerequisite: | lp:~henninge/launchpad/bug-581746-serialization-error | ||||
Diff against target: |
72 lines (+43/-6) 3 files modified
lib/canonical/buildd/debian/changelog (+15/-5) lib/canonical/buildd/debian/control (+1/-1) lib/canonical/buildd/debian/preinst (+27/-0) |
||||
To merge this branch: | bzr merge lp:~henninge/launchpad/bug-557347-packaging | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Nelson (community) | code | Approve | |
Jelmer Vernooij (community) | code* | Approve | |
Canonical Launchpad Engineering | code | Pending | |
Review via email: mp+25627@code.launchpad.net |
Commit message
Improved buildd installation by adding a preinst script that checks for running builds. Also added apache2 dependency.
Description of the change
Nice additions to keep the admins happy.
Adding the apache2 dependency is trivial.
The new preinst script works on the simple fact that the 'buildlog' file is removed after each build and thus can serve as an indicator for a running build. This was discussed with bigjools.
The changelog also refers to an important change by wgrant that has so far not reached the builders.
To post a comment you must log in.
Was it intentional to mention the changes from Danilo in the changelog now as well?
Otherwise, seems good.