Code review comment for lp:~henninge/launchpad/bug-523810-needs-information-age

= Bug 523810 =

The import queue gardener removes entries from the import queue that have reached a certain age in certain states. The age is configurable through a look-up table and the new "Needs Information" status needs an entry in that table. The maximum age should be identical to "Needs Review" for starters.

== Implementation details ==

Driven by the want to extend test coverage to all entry states that are being cleaned out I moved the look-up table to the interface module where it can be reached from the test.

I also found a nice little use of the with statement again. ;-)

== Tests ==

Run all autoapproval test to verify that the introduction of the GardenerDbUserMixin did not mess up existing tests.

bin/test -vvt autoapproval

== Demo/QA ==

In order to not have to wait half a year for an entry to expire on staging, some SQL magic will be needed to make an entry in the "Needs Information" stage that old. Then wait for a day or so to see it disappear. Staging updates might be a nuissance here.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/translations/interfaces/translationimportqueue.py
  lib/lp/translations/model/translationimportqueue.py
  lib/lp/translations/tests/test_autoapproval.py

== Pylint notices ==

lib/lp/translations/interfaces/translationimportqueue.py
    12: [F0401] Unable to import 'lazr.enum' (No module named enum)
    22: [F0401] Unable to import 'lazr.restful.interface' (No module named restful)
    23: [F0401] Unable to import 'lazr.restful.fields' (No module named restful)
    24: [F0401] Unable to import 'lazr.restful.declarations' (No module named restful)