Code review comment for lp:~henninge/launchpad/bug-482267

Am 17.11.2009 17:14, Edwin Grubbs schrieb:
> Review: Approve code
> Hi Henning,
>
> Your changes look good. I just have one suggestion below.
>
> merge-approved
>

Thank you very much! ;)

> Here is another thought of how you can keep the "and" but get rid of the
> double negative. You can take it or leave it.
>
> if new_status == RosettaImportStatus.APPROVED:
> if can_admin and self.import_into is None:
> pass
> else:
> return False
>

Ah, good idea. I was not really happy with the flow in setStatus anyway,
all these "return False" were confusing. I changed similar to your
suggestions that is much clearer (and has no double negative ;).
Incremental diff will be pasted.

Henning