Code review comment for lp:~henninge/launchpad/bug-482267

Here is the incremental diffs wrt the previous review.

=== modified file 'lib/lp/translations/model/translationimportqueue.py'
--- lib/lp/translations/model/translationimportqueue.py 2009-11-17 09:50:33 +0000
+++ lib/lp/translations/model/translationimportqueue.py 2009-11-17 10:55:09 +0000
@@ -310,7 +310,7 @@
             # that's only possible if we know where to import it
             # (import_into not None).
             return False
- if (new_status == RosettaImportStatus.BLOCKED and not can_admin):
+ if new_status == RosettaImportStatus.BLOCKED and not can_admin:
             # Only administrators are able to set an entry to BLOCKED.
             return False
         if (new_status in (RosettaImportStatus.FAILED,
@@ -319,7 +319,7 @@
             # Only scripts set these statuses and they report as a rosetta
             # expert.
             return False
- return (self.isUserUploaderOrOwner(user) or can_admin)
+ return self.isUserUploaderOrOwner(user) or can_admin

     def setStatus(self, new_status, user):
         """See `ITranslationImportQueueEntry`."""

=== modified file 'lib/lp/translations/tests/test_translationimportqueue.py'
--- lib/lp/translations/tests/test_translationimportqueue.py 2009-11-17 09:51:40 +0000
+++ lib/lp/translations/tests/test_translationimportqueue.py 2009-11-17 11:03:11 +0000
@@ -17,14 +17,14 @@
 from canonical.testing import LaunchpadZopelessLayer

-class TestTranslationImpportQueueEntryStatus(TestCaseWithFactory):
+class TestTranslationImportQueueEntryStatus(TestCaseWithFactory):
     """Test handling of the status of a queue entry."""

     layer = LaunchpadZopelessLayer

     def setUp(self):
         """Set up context to test in."""
- super(TestTranslationImpportQueueEntryStatus, self).setUp()
+ super(TestTranslationImportQueueEntryStatus, self).setUp()

         self.queue = getUtility(ITranslationImportQueue)
         self.rosetta_experts = (
@@ -100,7 +100,7 @@
             self.factory.makeTranslationGroup(self.ubuntu_group_owner))

     def test_canSetStatus_ubuntu_translation_group(self):
- # Owners of the Ubuntu translation Groups can set entries
+ # Owners of the Ubuntu translation Groups can set entries to approved
         # that are targeted to Ubuntu.
         self._setUpUbuntu()
         ubuntu_entry = self.queue.addOrUpdateEntry(