Launchpad itself

Code review comment for lp:~henninge/launchpad/bug-461818

  1. bug-461818
  2. Merge into devel
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Good branch overall, with some much-needed cleanup. A few changes discussed on IRC:

 * just_for_count is ugly; replace with do_prefetch and use the existing ordering parameter if necessary.

 * A comment needed work.

 * It'd be nice, though not absolutely necessary at this point, to have the SQL conditions rewritten in Storm.

Jeroen

review: Approve (code)

« Back to merge proposal