Code review comment for lp:~henninge/launchpad/bug-461756

Revision history for this message
Данило Шеган (danilo) wrote :

From IRC:

<danilos> henninge, just one question about yours: is there a reason not to default to ordered_by_names=True?
<henninge> danilos: the risk of breaking other code/tests. That is the only reason.
<henninge> backward compatibility
<danilos> henninge, right, it'd be nice to see how much stuff breaks, but not that important right now

So, while it'd be nice to run at least a full lp.translations test suite and see exactly what breaks if we default to True (especially if it ends up not being much, so we can fix it), it's not a requirement for landing this branch.

Great work!

review: Approve

« Back to merge proposal