Merge lp:~henn/firefox/fix-for-1665535 into lp:firefox/trunk

Proposed by Jay Hennessey
Status: Rejected
Rejected by: Rico Tzschichholz
Proposed branch: lp:~henn/firefox/fix-for-1665535
Merge into: lp:firefox/trunk
Diff against target: 63 lines (+14/-2)
4 files modified
debian/changelog (+5/-2)
debian/usr.bin.firefox.apparmor.12.04 (+3/-0)
debian/usr.bin.firefox.apparmor.13.10 (+3/-0)
debian/usr.bin.firefox.apparmor.14.10 (+3/-0)
To merge this branch: bzr merge lp:~henn/firefox/fix-for-1665535
Reviewer Review Type Date Requested Status
Jamie Strandboge (community) Disapprove
Chris Coulson Pending
Rico Tzschichholz Pending
Mozilla Team Pending
Review via email: mp+317576@code.launchpad.net

Commit message

Fix LP: #1665535 - Enable webcam access in apparmor profile for WebRTC

Description of the change

Fix LP: #1665535 - Enable webcam access in apparmor profile for WebRTC

To post a comment you must log in.
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

This access should be added to /etc/apparmor.d/abstractions/ubuntu-browsers.d/multimedia instead. The firefox profile edited here is meant to be minimal, with abstractions from /etc/apaprmor.d/abstractions/ubuntu-browsers.d/ used via /etc/apaprmor.d/abstractions/ubuntu-browsers.d/firefox. By default, /etc/apaprmor.d/abstractions/ubuntu-browsers.d/firefox will include multimedia.

review: Disapprove

Unmerged revisions

2075. By Jay Hennessey

Fix LP: #1665535 - Enable webcam access in apparmor profile for WebRTC

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2017-02-07 09:29:02 +0000
+++ debian/changelog 2017-02-17 04:47:47 +0000
@@ -1,4 +1,4 @@
1firefox-trunk (53.0~a1~hg20170111r328927-0ubuntu1) UNRELEASED; urgency=medium1firefox-trunk (53.0~a1~hg20170111r328927-0ubuntu2) UNRELEASED; urgency=medium
22
3 [ Chris Coulson ]3 [ Chris Coulson ]
4 * Update unity-menubar.patch with the latest version submitted upstream4 * Update unity-menubar.patch with the latest version submitted upstream
@@ -9,7 +9,10 @@
9 [ Rico Tzschichholz ]9 [ Rico Tzschichholz ]
10 * Unconditionally build-dep on libffi-dev10 * Unconditionally build-dep on libffi-dev
1111
12 -- Rico Tzschichholz <ricotz@ubuntu.com> Mon, 02 Jan 2017 12:33:44 +010012 [ Jason Hennessey ]
13 * Fix LP: #1665535 - Enable webcam access in apparmor profile for WebRTC
14
15 -- <henn@users.sourceforge.net> Fri, 17 Feb 2017 04:23:11 +0000
1316
14firefox-trunk (52.0~a1~hg20161106r321308-0ubuntu1) yakkety; urgency=medium17firefox-trunk (52.0~a1~hg20161106r321308-0ubuntu1) yakkety; urgency=medium
1518
1619
=== modified file 'debian/usr.bin.firefox.apparmor.12.04'
--- debian/usr.bin.firefox.apparmor.12.04 2017-02-07 09:29:02 +0000
+++ debian/usr.bin.firefox.apparmor.12.04 2017-02-17 04:47:47 +0000
@@ -55,6 +55,9 @@
55 /etc/timezone r,55 /etc/timezone r,
56 /etc/wildmidi/wildmidi.cfg r,56 /etc/wildmidi/wildmidi.cfg r,
5757
58 # For HTML5 webcam access
59 /dev/video[0-9]* rw,
60
58 # firefox specific61 # firefox specific
59 /etc/firefox*/ r,62 /etc/firefox*/ r,
60 /etc/firefox*/** r,63 /etc/firefox*/** r,
6164
=== modified file 'debian/usr.bin.firefox.apparmor.13.10'
--- debian/usr.bin.firefox.apparmor.13.10 2017-02-07 09:29:02 +0000
+++ debian/usr.bin.firefox.apparmor.13.10 2017-02-17 04:47:47 +0000
@@ -58,6 +58,9 @@
58 /etc/timezone r,58 /etc/timezone r,
59 /etc/wildmidi/wildmidi.cfg r,59 /etc/wildmidi/wildmidi.cfg r,
6060
61 # For HTML5 webcam access
62 /dev/video[0-9]* rw,
63
61 # firefox specific64 # firefox specific
62 /etc/firefox*/ r,65 /etc/firefox*/ r,
63 /etc/firefox*/** r,66 /etc/firefox*/** r,
6467
=== modified file 'debian/usr.bin.firefox.apparmor.14.10'
--- debian/usr.bin.firefox.apparmor.14.10 2017-02-07 09:29:02 +0000
+++ debian/usr.bin.firefox.apparmor.14.10 2017-02-17 04:47:47 +0000
@@ -78,6 +78,9 @@
78 /etc/timezone r,78 /etc/timezone r,
79 /etc/wildmidi/wildmidi.cfg r,79 /etc/wildmidi/wildmidi.cfg r,
8080
81 # For HTML5 webcam access
82 /dev/video[0-9]* rw,
83
81 # firefox specific84 # firefox specific
82 /etc/firefox*/ r,85 /etc/firefox*/ r,
83 /etc/firefox*/** r,86 /etc/firefox*/** r,

Subscribers

People subscribed via source and target branches