Mozilla Firefox

Merge lp:~henn/firefox/fix-for-1665535 into lp:firefox/trunk

  1. fix-for-1665535
  2. Merge into firefox-trunk.head
Proposed by Jay Hennessey
Status: Rejected
Rejected by: Rico Tzschichholz
Proposed branch: lp:~henn/firefox/fix-for-1665535
Merge into: lp:firefox/trunk
Diff against target: 63 lines (+14/-2)
4 files modified
debian/changelog (+5/-2)
debian/usr.bin.firefox.apparmor.12.04 (+3/-0)
debian/usr.bin.firefox.apparmor.13.10 (+3/-0)
debian/usr.bin.firefox.apparmor.14.10 (+3/-0)
To merge this branch: bzr merge lp:~henn/firefox/fix-for-1665535
Reviewer Review Type Date Requested Status
Jamie Strandboge (community) Disapprove
Chris Coulson Pending
Rico Tzschichholz Pending
Mozilla Team Pending
Review via email: mp+317576@code.launchpad.net

Commit message

Fix LP: #1665535 - Enable webcam access in apparmor profile for WebRTC

Description of the change

Fix LP: #1665535 - Enable webcam access in apparmor profile for WebRTC

To post a comment you must log in.
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

This access should be added to /etc/apparmor.d/abstractions/ubuntu-browsers.d/multimedia instead. The firefox profile edited here is meant to be minimal, with abstractions from /etc/apaprmor.d/abstractions/ubuntu-browsers.d/ used via /etc/apaprmor.d/abstractions/ubuntu-browsers.d/firefox. By default, /etc/apaprmor.d/abstractions/ubuntu-browsers.d/firefox will include multimedia.

review: Disapprove

Unmerged revisions

2075. By Jay Hennessey

Fix LP: #1665535 - Enable webcam access in apparmor profile for WebRTC

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2017-02-07 09:29:02 +0000
3+++ debian/changelog 2017-02-17 04:47:47 +0000
4@@ -1,4 +1,4 @@
5-firefox-trunk (53.0~a1~hg20170111r328927-0ubuntu1) UNRELEASED; urgency=medium
6+firefox-trunk (53.0~a1~hg20170111r328927-0ubuntu2) UNRELEASED; urgency=medium
7
8 [ Chris Coulson ]
9 * Update unity-menubar.patch with the latest version submitted upstream
10@@ -9,7 +9,10 @@
11 [ Rico Tzschichholz ]
12 * Unconditionally build-dep on libffi-dev
13
14- -- Rico Tzschichholz <ricotz@ubuntu.com> Mon, 02 Jan 2017 12:33:44 +0100
15+ [ Jason Hennessey ]
16+ * Fix LP: #1665535 - Enable webcam access in apparmor profile for WebRTC
17+
18+ -- <henn@users.sourceforge.net> Fri, 17 Feb 2017 04:23:11 +0000
19
20 firefox-trunk (52.0~a1~hg20161106r321308-0ubuntu1) yakkety; urgency=medium
21
22
23=== modified file 'debian/usr.bin.firefox.apparmor.12.04'
24--- debian/usr.bin.firefox.apparmor.12.04 2017-02-07 09:29:02 +0000
25+++ debian/usr.bin.firefox.apparmor.12.04 2017-02-17 04:47:47 +0000
26@@ -55,6 +55,9 @@
27 /etc/timezone r,
28 /etc/wildmidi/wildmidi.cfg r,
29
30+ # For HTML5 webcam access
31+ /dev/video[0-9]* rw,
32+
33 # firefox specific
34 /etc/firefox*/ r,
35 /etc/firefox*/** r,
36
37=== modified file 'debian/usr.bin.firefox.apparmor.13.10'
38--- debian/usr.bin.firefox.apparmor.13.10 2017-02-07 09:29:02 +0000
39+++ debian/usr.bin.firefox.apparmor.13.10 2017-02-17 04:47:47 +0000
40@@ -58,6 +58,9 @@
41 /etc/timezone r,
42 /etc/wildmidi/wildmidi.cfg r,
43
44+ # For HTML5 webcam access
45+ /dev/video[0-9]* rw,
46+
47 # firefox specific
48 /etc/firefox*/ r,
49 /etc/firefox*/** r,
50
51=== modified file 'debian/usr.bin.firefox.apparmor.14.10'
52--- debian/usr.bin.firefox.apparmor.14.10 2017-02-07 09:29:02 +0000
53+++ debian/usr.bin.firefox.apparmor.14.10 2017-02-17 04:47:47 +0000
54@@ -78,6 +78,9 @@
55 /etc/timezone r,
56 /etc/wildmidi/wildmidi.cfg r,
57
58+ # For HTML5 webcam access
59+ /dev/video[0-9]* rw,
60+
61 # firefox specific
62 /etc/firefox*/ r,
63 /etc/firefox*/** r,

Subscribers

People subscribed via source and target branches