Code review comment for lp:~heathbar/switchboard-plug-pantheon-shell/fix-1036271

Revision history for this message
Tom Beckmann (tombeckmann) wrote :

I got approval by our designers now :)
One last thing that should be done is hide the box when there is only a single entry.
Also, the extra indentation for the try-catch block seems quite unnecessary here, as the try-catch already intends it once. And it'd be better if you could add a simple "warning (e.message);" in the catch clause instead of ignoring the error, so if something goes wrong you can ask the user to get us the terminal output and get useful information.

« Back to merge proposal