This is good, we definitely need feedback when waiting for the shuffle-queue to download. The shuffle buffer already starts playing, though.
MainActivity starts DownloadActivity, which checks the received intent for whether this is shuffle-play, and if it is, calls setShufflePlayEnabled(), which calls checkDownloads(), which calls checkShufflePlay(), which calls then play(0) IF it is the first time a shuffle-play has been started (id est, if shuffle play hasn't been stopped in the past).
On subsequent shuffle-play taps, should the music player do anything other than return the user to the place they were before? I need convincing it should do more.
I welcome the informational change for the user. With that only that change, I'd approve. Marking "Needs Fixing" to indicate that I so far don't want the other changes.
This is good, we definitely need feedback when waiting for the shuffle-queue to download. The shuffle buffer already starts playing, though.
MainActivity starts DownloadActivity, which checks the received intent for whether this is shuffle-play, and if it is, calls setShufflePlayE nabled( ), which calls checkDownloads(), which calls checkShufflePlay(), which calls then play(0) IF it is the first time a shuffle-play has been started (id est, if shuffle play hasn't been stopped in the past).
On subsequent shuffle-play taps, should the music player do anything other than return the user to the place they were before? I need convincing it should do more.
I welcome the informational change for the user. With that only that change, I'd approve. Marking "Needs Fixing" to indicate that I so far don't want the other changes.