Code review comment for lp:~hduran-8/juju-core/add_network_check_on_specified_machine

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

https://codereview.appspot.com/84880045/diff/1/environs/interface.go
File environs/interface.go (right):

https://codereview.appspot.com/84880045/diff/1/environs/interface.go#newcode170
environs/interface.go:170: ValidateNetworksForInstance(includedNetworks,
excludedNetworks []string, instance_id string) error
On 2014/04/07 09:29:40, fwereade wrote:
> Not 100%sure about this direction -- I'd rather not talk to the
provider if we
> have the info available in state. Dimitern, what's the status of the
pipeline
> that sets actual networks on machines?

We can set networks and NICs on machines in state, but the provisioner
does not do it yet - it will some time later today I hope.

https://codereview.appspot.com/84880045/

« Back to merge proposal