Code review comment for lp:~hduran-8/juju-core/add_network_check_on_specified_machine

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

Also, the kanban card mentioned deploy and add-unit for --to, and I
can't see the changes to the latter (add --(exclude)-networks args and
check them if --to is given, otherwise return an error if networks are
specified I think). Finally, we need to make sure if the user specifies
networks for both commands, all given networks must be in
include/excludeNetworks for the service itself (i.e. you cannot
add/remove networks from the service when deploying new units, just
restrict what networks will be enabled out of the initially given
networks for the service).

https://codereview.appspot.com/84880045/

« Back to merge proposal