Code review comment for lp:~hduran-8/juju-core/add_network_check_on_specified_machine

Revision history for this message
Horacio DurĂ¡n (hduran-8) wrote :

Reviewers: mp+214463_code.launchpad.net,

Message:
Please take a look.

Description:
Added --not/network compat verification for --to

I added ValidateNetworksForInstance to Environ
This method checks if te requested networks are
available in the instance selected with --to
and if the excluded networks are not in conflict
with already existing ones.
I added this to the Environ interface and mocked
the method in all the available providers.
This method is only required when SupportNetworks
from EnvironCapability is true

https://code.launchpad.net/~hduran-8/juju-core/add_network_check_on_specified_machine/+merge/214463

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/84880045/

Affected files (+149, -2 lines):
   A [revision details]
   M cmd/juju/deploy.go
   M environs/interface.go
   M juju/deploy.go
   M provider/azure/environ.go
   M provider/dummy/environs.go
   M provider/ec2/ec2.go
   M provider/joyent/environ.go
   M provider/local/environ.go
   M provider/maas/environ.go
   M provider/maas/environ_whitebox_test.go
   M provider/manual/environ.go
   M provider/openstack/provider.go
   M state/apiserver/client/client.go

« Back to merge proposal