Hi Horatio. Sorry for taking so long to review this branch. We normally keep branches to 400 lines.
I think there is too much duplication with other feature in juju-ci-tools and Python itself. My comments are inline, but in general, there is already a helper to bring up and tear down an env, you should use it because CI needs more control over what is under test then your main() provides. We do not want to write assertions when Python provides them for free. I think all the calls to assert can be written in fewer lines using unittest. https://docs.python.org/2/library/unittest.html#unittest.FunctionTestCase
Hi Horatio. Sorry for taking so long to review this branch. We normally keep branches to 400 lines.
I think there is too much duplication with other feature in juju-ci-tools and Python itself. My comments are inline, but in general, there is already a helper to bring up and tear down an env, you should use it because CI needs more control over what is under test then your main() provides. We do not want to write assertions when Python provides them for free. I think all the calls to assert can be written in fewer lines using unittest. /docs.python. org/2/library/ unittest. html#unittest. FunctionTestCas e
https:/