Code review comment for lp:~hduran-8/juju-ci-tools/add_status_ci_tests

Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you Horatio. This was a long branch to review. I like the actual testing done in this branch, but I believe there are easier ways to do it. My comments are inline. I also like the idea of a template to write new tests, and I think there is a context manager that makes writing test easier than what you choose.

Please run make lint to address style issues. you may want to try autopep8 which claims to reformat python to pep8 and pep257. In my experience, there will be some reformatting that is not specified by pep8

review: Needs Fixing (code)

« Back to merge proposal