Code review comment for lp:~hbee/openobject-addons/7.0-merge_purchase_requisitions_wkf_fix

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Can you please expand on the problems that you foresee? I don't see the problem so far.

Procurement orders can only refer to a single line. When the wizard in this branch unlinks a requisition because it has no lines, there should not be a purchase order refering to it.

When requisitions are merged and then later on split up again, updating the individual procurement orders subflow with the new requisition ids derived from the requisition lines should suffice. Then, when a requisition is cancelled, the procurement workflow should pick this up automatically.

While it is true that requisition lines do not have state, their requisitions do and the wizard only works on lines from draft requisitions (+ additional restrictions) so repartitioning those should not affect their procurement orders' workflow states.

Am I missing something?

« Back to merge proposal