Code review comment for lp:~hbee/openobject-addons/7.0-merge_purchase_requisitions_wkf_fix

Revision history for this message
Paulius Sladkevičius @ hbee (komsas) wrote :

Mine code redirects removed requisitions to a new created requisitions, that should be fine. Your concern about remaining lines is correct, that should be handled too.

I see problem that requisition line don't have states or workflow, like a task/stock move.
What about situation when half requisition lines will be merged others not, when procurement should go to done/cancel state? Theoretically I think it should go when both requisitions workflow are finished.

To solve this we should take similar why how is stock move or tasks are handled on the procurement, but problem is that we have procurement subflow to requisition not to requisition line.

« Back to merge proposal