Code review comment for lp:~hbee/openobject-addons/7.0-merge_purchase_requisitions_wkf_fix

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Thanks! I gather that this code redirects the requisition subflow on the procurement order. I think this change ignores the possibility of a requisition with remaining lines. The target branch for that reason moves the actual link betwee procurements and requisitions to the level of the requisition line. Therefore, it seems to me that the workflow should be redirected when the requisition_line_id is written to the procurement order, in make_po(). What do you think?

review: Needs Information

« Back to merge proposal