https://codereview.appspot.com/5976074/diff/4001/txzookeeper/managed.py#newcode189
txzookeeper/managed.py:189: log.error("error while restablish %r %s" %
(e, e))
Another minor: probably want some consistency in beginning with
uppercase. Not certain why you use log.error here, but log.exception
later for what appears to be a similar case.
+1, LGTM, just some minors
https:/ /codereview. appspot. com/5976074/ diff/4001/ txzookeeper/ managed. py managed. py (right):
File txzookeeper/
https:/ /codereview. appspot. com/5976074/ diff/4001/ txzookeeper/ managed. py#newcode153 managed. py:153: def cb_restablish_ session( self, e=None):
txzookeeper/
Presumably this should be cb_re_establish... but I don't see the
difference here with the easier synonym: restore. Good either way with
me.
https:/ /codereview. appspot. com/5976074/ diff/4001/ txzookeeper/ managed. py#newcode162 managed. py:162: # If its been explicitly closed, don't
txzookeeper/
restablish.
it's... re-establish
(or are you saying something about being restful? ;) )
https:/ /codereview. appspot. com/5976074/ diff/4001/ txzookeeper/ managed. py#newcode166 managed. py:166: # If its a stale handle, don't restablish
txzookeeper/
it's... re-establish
https:/ /codereview. appspot. com/5976074/ diff/4001/ txzookeeper/ managed. py#newcode174 managed. py:174: # Its already been restablished, don't
txzookeeper/
restablish.
It's... re-established... re-establish
https:/ /codereview. appspot. com/5976074/ diff/4001/ txzookeeper/ managed. py#newcode183 managed. py:183: # Restablish
txzookeeper/
I'm not going to mark any more of these!
https:/ /codereview. appspot. com/5976074/ diff/4001/ txzookeeper/ managed. py#newcode189 managed. py:189: log.error("error while restablish %r %s" %
txzookeeper/
(e, e))
Another minor: probably want some consistency in beginning with
uppercase. Not certain why you use log.error here, but log.exception
later for what appears to be a similar case.
https:/ /codereview. appspot. com/5976074/ diff/4001/ txzookeeper/ tests/test_ managed. py tests/test_ managed. py (right):
File txzookeeper/
https:/ /codereview. appspot. com/5976074/ diff/4001/ txzookeeper/ tests/test_ managed. py#newcode110 tests/test_ managed. py:110: """Reset fires a synthentic
txzookeeper/
client event, and clears watches.
no need for comma
https:/ /codereview. appspot. com/5976074/