https://codereview.appspot.com/5976074/diff/1/txzookeeper/managed.py#newcode138
txzookeeper/managed.py:138: """Called on intercept of session expiration
to restablish the session.
I'm pretty sure there are 2 es in re-establish, and that the hyphen may
have fallen out of common use but remains IMO more readable. As you
wish.
This looks very nice indeed, but the vagueness of the "comes at a cost"
comment makes me wonder what I'm missing...
https:/ /codereview. appspot. com/5976074/ diff/1/ txzookeeper/ managed. py managed. py (right):
File txzookeeper/
https:/ /codereview. appspot. com/5976074/ diff/1/ txzookeeper/ managed. py#newcode66 managed. py:66: mgr # keep the flakes happy
txzookeeper/
Can't you just do:
with self._ctx():
?
https:/ /codereview. appspot. com/5976074/ diff/1/ txzookeeper/ managed. py#newcode70 managed. py:70: mgr # keep the flakes happy
txzookeeper/
Ditto
https:/ /codereview. appspot. com/5976074/ diff/1/ txzookeeper/ managed. py#newcode122 managed. py:122: come at a cost though.
txzookeeper/
Please expand ;).
https:/ /codereview. appspot. com/5976074/ diff/1/ txzookeeper/ managed. py#newcode138 managed. py:138: """Called on intercept of session expiration
txzookeeper/
to restablish the session.
I'm pretty sure there are 2 es in re-establish, and that the hyphen may
have fallen out of common use but remains IMO more readable. As you
wish.
https:/ /codereview. appspot. com/5976074/ diff/1/ txzookeeper/ managed. py#newcode140 managed. py:140: This will reconnect to zk, restabslish
txzookeeper/
ephemerals, and trigger watches.
I like the word "restabslish", but ditto.
https:/ /codereview. appspot. com/5976074/ diff/1/ txzookeeper/ tests/test_ managed. py tests/test_ managed. py (right):
File txzookeeper/
https:/ /codereview. appspot. com/5976074/ diff/1/ txzookeeper/ tests/test_ managed. py#newcode169 tests/test_ managed. py:169: # It takes some time to propogate propagate/
txzookeeper/
(1/3 session time as ping)
s/propogate/
https:/ /codereview. appspot. com/5976074/