This looks very nice too, thanks!
Just a couple of details:
[1]
+ elif provider_type == "lxc":
Please do not forget to rename the provider type to "local" before making this public.
[2]
+ output = subprocess.check_output(["hostname", "-f"])
Why is this different for orchestra? Won't this fail if thethe release. machine doesn't have a properly assigned domain name? I suspect it will, and suggest using the same implementation of the local case there as well.
« Back to merge proposal
This looks very nice too, thanks!
Just a couple of details:
[1]
+ elif provider_type == "lxc":
Please do not forget to rename the provider type to "local"
before making this public.
[2]
+ output = subprocess. check_output( ["hostname" , "-f"])
Why is this different for orchestra? Won't this fail if thethe release.
machine doesn't have a properly assigned domain name? I suspect
it will, and suggest using the same implementation of the local
case there as well.