Code review comment for lp:~hazmat/pyjuju/security-node-policy-def

Revision history for this message
Benjamin Saller (bcsaller) wrote :

LGTM as well.

[4] Want to verify that Principals don't need a detach method because the connection is implicitly scoped to the secured session?

[5] The way `owner` is used I'm not sure you really need to track it at all. It only maps to an `all` token once. Similar to point [2]

[6] add_rule should make more clear the signature of rules given that they don't have a base class or imply an interface. docstring change.

review: Approve

« Back to merge proposal