https://codereview.appspot.com/7241062/diff/3001/juju/hooks/invoker.py#newcode255
juju/hooks/invoker.py:255:
list(set(idents).intersection(set(self._relation_contexts))))
On 2013/02/01 16:11:10, bcsaller wrote:
> It doesn't look like you test this method after its change to be a
generator.
> You previously returned the generator though it looks like so it would
have been
> yielded on anyway, I suspect this is still ok.
it was returning a deferred with eventual value of list of strings
idents in either case, so should be fine (and verified end2end by
existing test suite).
thanks for the review
https:/ /codereview. appspot. com/7241062/ diff/3001/ juju/hooks/ invoker. py invoker. py (right):
File juju/hooks/
https:/ /codereview. appspot. com/7241062/ diff/3001/ juju/hooks/ invoker. py#newcode255 invoker. py:255: idents) .intersection( set(self. _relation_ contexts) )))
juju/hooks/
list(set(
On 2013/02/01 16:11:10, bcsaller wrote:
> It doesn't look like you test this method after its change to be a
generator.
> You previously returned the generator though it looks like so it would
have been
> yielded on anyway, I suspect this is still ok.
it was returning a deferred with eventual value of list of strings
idents in either case, so should be fine (and verified end2end by
existing test suite).
https:/ /codereview. appspot. com/7241062/