Code review comment for lp:~hazmat/pyjuju/sane-relation-ids

Revision history for this message
Benjamin Saller (bcsaller) wrote :

LGTM, subtle issue you're fixing there.

https://codereview.appspot.com/7241062/diff/3001/juju/hooks/invoker.py
File juju/hooks/invoker.py (right):

https://codereview.appspot.com/7241062/diff/3001/juju/hooks/invoker.py#newcode255
juju/hooks/invoker.py:255:
list(set(idents).intersection(set(self._relation_contexts))))
It doesn't look like you test this method after its change to be a
generator. You previously returned the generator though it looks like so
it would have been yielded on anyway, I suspect this is still ok.

https://codereview.appspot.com/7241062/

« Back to merge proposal