Code review comment for lp:~hazmat/pyjuju/repository-broken-charms

Revision history for this message
William Reade (fwereade) wrote :

LGTM

https://codereview.appspot.com/5841056/diff/1/juju/charm/errors.py
File juju/charm/errors.py (right):

https://codereview.appspot.com/5841056/diff/1/juju/charm/errors.py#newcode30
juju/charm/errors.py:30: """Raised when an error in the info file of a
charm is found."""
MetaDataError seems to be missing a test; might be worth adding one,
however trivial it may be; and it also appears to have no methods that
need to exist.

https://codereview.appspot.com/5841056/

« Back to merge proposal